GetSize implementation for SubmitSolutionJd is incomplete

[plebhash]

while working on #1003 I got stuck.

I kept getting FramingSv2Error(BinarySv2Error(WriteError)) even though my SubmitSolution message was perfectly defined on the MG test.

After a few hours of debugging, I found the root cause:

stratum/protocols/v2/subprotocols/job-declaration/src/submit_solution.rs

Lines 12 to 34 in 7841021

	pub struct SubmitSolutionJd<'decoder> {
	#[cfg_attr(feature = "with_serde", serde(borrow))]
	pub extranonce: B032<'decoder>,
	#[cfg_attr(feature = "with_serde", serde(borrow))]
	pub prev_hash: U256<'decoder>,
	pub ntime: u32,
	pub nonce: u32,
	pub nbits: u32,
	pub version: u32,
	}
	#[cfg(feature = "with_serde")]
	use binary_sv2::GetSize;
	#[cfg(feature = "with_serde")]
	impl<'d> GetSize for SubmitSolutionJd<'d> {
	fn get_size(&self) -> usize {
	self.extranonce.get_size()
	+ self.prev_hash.get_size()
	+ self.ntime.get_size()
	+ self.nonce.get_size()
	+ self.nbits.get_size()
	}
	}

the GetSize implementation is not accounting for self.version.get_size()!

that is causing NoiseEncoder to allocate a buffer that's smaller than what is actually needed, which eventually triggers FramingSv2Error(BinarySv2Error(WriteError)) during encoding

[GitGab19]

Closed by #1019