Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The haltHeight on CosmosFullNode should accept 0 as a valid value #309

Closed
DavidNix opened this issue Jun 10, 2023 · 2 comments · Fixed by #311
Closed

The haltHeight on CosmosFullNode should accept 0 as a valid value #309

DavidNix opened this issue Jun 10, 2023 · 2 comments · Fixed by #311
Assignees
@DavidNix
Labels
bug Something isn't working

Comments

@DavidNix
Copy link
Contributor

No description provided.

@DavidNix DavidNix added the bug Something isn't working label Jun 10, 2023
@DavidNix DavidNix changed the title The haltHeight should accept 0 as a valid value The haltHeight on CosmosFullNode should accept 0 as a valid value Jun 10, 2023
@jonathanpberger
Copy link
Contributor

Assigning to @danbryan as "good intro to golang".

@DavidNix DavidNix assigned DavidNix and unassigned danbryan Jun 20, 2023
@DavidNix
Copy link
Contributor Author

DavidNix commented Jun 20, 2023 •
edited
Loading

Re-assigning. It won't be a great intro to Go since the operator framework parses comments and creates code for you in this case. This story, specifically allow setting cosmwasm version, would be a better intro.

@DavidNix DavidNix mentioned this issue Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidNix DavidNix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CosmosFullNode): Allow 0 halt height strangelove-ventures/cosmos-operator
3 participants
@jonathanpberger @DavidNix @danbryan