Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Add option for ignoring components. #23

Open
cristianoliveira opened this issue Feb 26, 2018 · 1 comment
Open

Add option for ignoring components. #23

cristianoliveira opened this issue Feb 26, 2018 · 1 comment

Comments

@cristianoliveira
Copy link

Would be nice to have an option to either ignore components or props (perhaps respecting the null value). We are having a problem when using this plugin since one of our components have different behaviors based on a combination of props.

For instance, It doesn't accept icon and onRemove props at the same time. The problem is when using this plugin it always injects the onRemove props making impossible to show all these behaviors on the storybook. :(

I took a look at the code but couldn't find an option to do it.

cristianoliveira added a commit to sumup-oss/circuit-ui that referenced this issue Feb 26, 2018
  We noticed that Smart knob injects default functions and, for now,
  there is no option to avoid this behavior.
  A issue has been opened in order to add this option into the plugin
  storybook-eol/addon-smart-knobs#23
cristianoliveira added a commit to sumup-oss/circuit-ui that referenced this issue Feb 27, 2018
  We noticed that Smart knob injects default functions and, for now,
  there is no option to avoid this behavior.
  A issue has been opened in order to add this option into the plugin
  storybook-eol/addon-smart-knobs#23
@ndelangen
Copy link
Contributor

@cristianoliveira Do you have an idea on how this would work? If there something I can do that would help you make a PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants