Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary storage: reduce number of service instantiations #21

Open
Erikvv opened this issue Mar 14, 2022 · 1 comment
Open

Primary storage: reduce number of service instantiations #21

Erikvv opened this issue Mar 14, 2022 · 1 comment

Comments

@Erikvv
Copy link
Contributor

Erikvv commented Mar 14, 2022 •
edited
Loading

When debugging I found that the services were instantiated multiple times per request. The dlopen() call is cached but the openProject() call is not. This is a network call and bad for performance.

I expect that the Nextcloud dependency injection container creates one instance per service. Need to investigate and possibly file a bug with Nextcloud.

This issue only applies when using Storj as primary storage.
@Erikvv Erikvv changed the title Reduce number of service instances Reduce number of service instantiations Mar 14, 2022
@Erikvv
Copy link
Contributor Author

Erikvv commented Apr 17, 2022

It seems there are 2 instantiations of StorjObjectStore when using the file browser which is not as bad as I feared.

@Erikvv Erikvv changed the title Reduce number of service instantiations Reduce number of service instantiations (primary storage) Oct 27, 2022
@Erikvv Erikvv changed the title Reduce number of service instantiations (primary storage) Primary storage: reduce number of service instantiations Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Erikvv