Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new features make more compatibility with stm32f4xx-hal #54

Open
no111u3 opened this issue Jun 29, 2020 · 7 comments
Open

Update to new features make more compatibility with stm32f4xx-hal #54

no111u3 opened this issue Jun 29, 2020 · 7 comments

Comments

@no111u3
Copy link
Contributor

no111u3 commented Jun 29, 2020

I found more update version of library - https://github.com/dtjones190/stm32f7xx-hal.
Could you ask me about plans to update with common state such as stm32f4xx-hal, I can create PR based on upper changes.

@mvertescher
Copy link
Member

Cool! I'm happy to review and merge any new functionality or fixes if folks open up PRs. The stm32f4xx-hal is certainly more complete than this crate ATM and I agree it would be good to keep things as similar as possible. PRs are definitely welcome to make this crate more compatible with the other stm32 hals!

@no111u3
Copy link
Contributor Author

no111u3 commented Jul 2, 2020

Create first PR with little cosmetic changes #57

@no111u3
Copy link
Contributor Author

no111u3 commented Jul 4, 2020

Add PLL Q configuration for usb #59

@no111u3
Copy link
Contributor Author

no111u3 commented Jul 8, 2020

@mvertescher could You review #59 and #60? - first unblock me for adding other mcu blocks support (usb, sdio, sai and rnd depends on 48 MHz clock source), second provide me more options for test usb stack for stm32f7 mcus.

@mvertescher
Copy link
Member

Np @no111u3, I'll move forward with reviewing/merging asap. I've pinged some folks as well to get any final feedback.

@no111u3
Copy link
Contributor Author

no111u3 commented Aug 31, 2020

@mvertescher I rewrite RCC configuration #74: to work version with highly compatible to previous version, so It add configuration for configure USB clock with or without use PLL for system clock. (It fully replace PR #59). Could you review it. Thanks.

@mvertescher
Copy link
Member

Thanks for the update, I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants