Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transmit pause configuration #41

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

mahu-wm
Copy link
Contributor

@mahu-wm mahu-wm commented Dec 1, 2023

The DAR (Disable Auto Retransmission) bit was used erroneously. Correctly, the TXP (Transmit Pause) bit should be used. Negation is not necessary, either.

The DAR (Disable Auto Retransmission) bit was used erroneously.
Correctly, the TXP (Transmit Pause) bit should be used.
Negation is not necessary, either.
@richardeoin
Copy link
Member

This looks good to me, thank you! I checked against RM0440 and RM0468.

@richardeoin richardeoin added this pull request to the merge queue Dec 9, 2023
Merged via the queue into stm32-rs:master with commit 7955ae2 Dec 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants