Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsne and filter errors on all-pharma #2418

Open
karishma-gangwani opened this issue Nov 22, 2024 · 2 comments
Open

Tsne and filter errors on all-pharma #2418

karishma-gangwani opened this issue Nov 22, 2024 · 2 comments
Assignees

Comments

@karishma-gangwani
Copy link
Contributor

karishma-gangwani commented Nov 22, 2024

I have informed @airenzp and shared session files for the following errors I am seeing:

  1. in filter tab - filter currently allows a user to extend below and above the range limits
  2. when divideBy is added for asparaginase normalized and color is molecular subtype on the tsne, the divideBy control label changes to ‘z’, and edit on the divideby term does not allow change to discrete mode for numeric term.

Please run node utils/getDataset.js allPharmacotyping from sjpp for downloading latest db and link to url

@xzhou82
Copy link
Collaborator

xzhou82 commented Nov 29, 2024

please clarify filter issue
in samplescatter, may hide divideBy option since it's confusing

@karishma-gangwani
Copy link
Contributor Author

please clarify filter issue in samplescatter, may hide divideBy option since it's confusing

for 1) I noticed this on the minimal violin UI when a filter is applied. For a drug or any numerical value with a strict upper limit, the minimal violin UI allows the user to enter values beyond the range, which looks confusing if normalized values are only within 0 to 1. For example, select any drug in all-pharma and input the range 0 < x < 2 in the filter. The shaded grey area over the violin plot extends rightwards to the further end even though there are no values present from 1 to 2.
2) Airen has fixed the second one so we can close this if 1) is not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants