Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Point class consistently #48

Merged
merged 13 commits into from
May 25, 2019
Merged

Use Point class consistently #48

merged 13 commits into from
May 25, 2019

Conversation

gregcorbett
Copy link
Collaborator

@gregcorbett gregcorbett commented May 25, 2019 •
edited
Loading

Resolves #40 and resolves #43

gregcorbett added 13 commits May 25, 2019 20:18
@gregcorbett
Document when to use Points and when to use tuples
c72a116
@gregcorbett
Add helper methods for maths operations on Points
be428d6
@gregcorbett
Make the Point object extend tuple
5fc65c9 
- so Points can be passed directly to pygame
- helper methods also use tuple syntax so
  tuples can be added to Points
@gregcorbett
Make Component use Points for screen locations
098b647
@gregcorbett
Make Icon use Point objects for screen locations
7a919cb 
- This makes the math code here less repetitive
@gregcorbett
Make Board use Points objects for screen locations
ed938f7
@gregcorbett
Make BeeBot use Points for screen/logic positions
bd72614
@gregcorbett
Make CommandLog use Points for screen locations
73d6886
@gregcorbett
Make GameWindow pass Points for screen locations
6f539a7
@gregcorbett
Make Scenario use Points for BeeBot start position
f851ae6 
- this is fine because the Point class extends
  the tuple class.
@gregcorbett
Clarify why Arrow Enums are not defined as Points
19883b0
@gregcorbett
Update test cases to use Point class
0997178
@gregcorbett
Add a unittest for the Point class
058a248
@gregcorbett gregcorbett self-assigned this May 25, 2019
@gregcorbett
Copy link
Collaborator Author

codeclimate issues captured in #49 and #50

@gregcorbett gregcorbett merged commit ebbad61 into stfc:develop May 25, 2019
@gregcorbett gregcorbett deleted the point_everywhere branch May 25, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregcorbett gregcorbett

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@gregcorbett