-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Stop Button like the BeeBot Stop Button #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Beebot class and start_logic loop structure to allow stop button work as physical beebot works. - Occaisional Runtime Error: dictionary changed size during iteration
- so we can have a Go and Stop Button in the same place
- so we can set displayed for individual Buttons
- so that only one runs per loop - make Stop button work better because it prevents Go and Stop being triggered in the same loop
- this was made easier by replacing flip with two seperate functions and required minimal changes/additions to GameWindow
- incase any movement events have already been pushed
- prevents odd cases like the BeeBot continue to move after being reset, the BeeBot getting stuck in running mode with no instructions or the BeeBot being 'programmed' while running.
gregcorbett
force-pushed
the
stop_button
branch
from
November 2, 2017 22:25
e799b87
to
5cda31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13
stuck behind the entire memory contents. Every GameLoop, if the BeeBot is
'running' it will either move or push out an single instruction or stop moving.
This allows for the 'Stop' functionality to work.
'Runtime Error: dictionary changed size during iteration' problems.
it's display state can be toggled.
Go/Stop Button
changed to elifs and there order was changed so only one gets executed per
game loop which helps with events being handled in the correct order and
only 'one at a time'.
led to some changes in the test case to support mouse clicks rather than
events being processed.