Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-binary plugin does not support whitespace #1031

Open
skyshineb opened this issue Nov 11, 2024 · 1 comment
Open

custom-binary plugin does not support whitespace #1031

skyshineb opened this issue Nov 11, 2024 · 1 comment

Comments

@skyshineb
Copy link

skyshineb commented Nov 11, 2024

I've recently stuck with error on other project using this plugin.
I have git installed on Windows in C:\Program Files\Git with respective binary path C:\Program Files\Git\bin\git.exe and when SimpleGit is instantiated it receives this path as custom binary.
But it will not pass the Regex check ^([a-z]:)?([a-z0-9/.\\_-]+)$ in simple-git/src/lib/plugins/custom-binary.plugin.ts because it does not contain whitespace nor ~(to use with shorten windows path).

Can someone explain to me why this is desired behavior or maybe it's a bug?

@skyshineb
Copy link
Author

@steveukx Hi! Can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant