-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.6 works waaay better than Python 3.7 #257
Comments
To be fair we do specify 3.6 especially in the travis ci
…On Fri, Oct 19, 2018, 4:08 AM Darryl Lee ***@***.***> wrote:
So many dependency errors trying to install requirements with Python 3.7
on OS X 10.13.4. Exactly zero errors when I rolled back to Python 3.6.5.
Noting that in the docs might save some other people the headache I just
went through. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#257>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJN8OEUNbDJJ8DcfOcFI7fK5ipTMehu8ks5umYiOgaJpZM4Xv3lE>
.
|
The Dockerfile just says I'll try to take a look at this some time next week, and see if I can't resolve any issues. [it'd also probably be a good idea to update some of the packages from requirements.txt, as the versions there are a bit old]. That is, unless someone else wants to do it first! |
#worksforme ;)
…On Fri, Oct 19, 2018, 8:26 AM Mike Miller ***@***.***> wrote:
The Dockerfile just says alpine:latest, and installs python3. This will
break at some point, probably rather soon :-)
I'll try to take a look at this some time next week, and see if I can't
resolve any issues. [it'd also probably be a good idea to update some of
the packages from requirements.txt, as the versions there are a bit old].
That is, unless someone else wants to do it first!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#257 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJN8OHrc5yYj3IM9_BsmXwkxGCc89XtLks5umcUMgaJpZM4Xv3lE>
.
|
Totally unrelated, but would you mind a PR that runs the entire project through autopep8? My editor keeps wanting to do it anyway, but I don't want to submit formatting changes at the same time as functional changes, but I keep having to undo it's "helpful" changes :-) |
I'm not scared of multipurpose PRs as long as you tell me what the multi
purpose are. But in any case I'd love auto pep8 PRs in the future.
…On Fri, Oct 19, 2018, 8:34 AM Mike Miller ***@***.***> wrote:
Totally unrelated, but would you mind a PR that runs the entire project
through autopep8? My editor keeps wanting to do it anyway, but I don't want
to submit formatting changes at the same time as functional changes, but I
keep having to undo it's "helpful" changes :-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#257 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJN8OK-M2eLVFQc9v9lRafKCSsSeZGSaks5umca5gaJpZM4Xv3lE>
.
|
ok. I personally hate them :-) In any case, autopep8 coming right up. |
We have tests. It will be fine.
…On Fri, Oct 19, 2018, 8:40 AM Mike Miller ***@***.***> wrote:
ok. I personally hate them :-)
In any case, autopep8 coming right up.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#257 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJN8OAAuwyt9NA4tjtK6iZB4agmOgAhmks5umcgxgaJpZM4Xv3lE>
.
|
@darryllee , can you explain a bit more about the issue(s) you saw? I just did a pip install on my Macbook (it's not internet facing, and so I didn't do anything more than run the server to confirm that it ran -- I can't run ngrok on it due to a corporate security issue), and I faced the following issues, but I want to make sure your cases are all covered:
I also tested under alpine (using |
If I remember correctly, downgrading pip got me a little further. But then for some reason I needed to rebuild cryptography, and I ran into this: pyca/cryptography#3489 |
Ok, thanks. That fits with what I saw. The reason, btw, is that cryptography is a bit of a bit to compile, and so most people use the wheel which is pre-compiled, but the version of cryptograhy in requirements.txt doesn't include a python 3.7 compliant wheel. Can I ask you to try PR #259 please? |
So many dependency errors trying to install requirements with Python 3.7 on OS X 10.13.4. Exactly zero errors when I rolled back to Python 3.6.5.
Noting that in the docs might save some other people the headache I just went through. Thanks!
The text was updated successfully, but these errors were encountered: