Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6 works waaay better than Python 3.7 #257

Open
darryllee opened this issue Oct 19, 2018 · 10 comments
Open

Python 3.6 works waaay better than Python 3.7 #257

darryllee opened this issue Oct 19, 2018 · 10 comments

Comments

@darryllee
Copy link

So many dependency errors trying to install requirements with Python 3.7 on OS X 10.13.4. Exactly zero errors when I rolled back to Python 3.6.5.

Noting that in the docs might save some other people the headache I just went through. Thanks!

@fergyfresh
Copy link
Collaborator

fergyfresh commented Oct 19, 2018 via email

@mikeage
Copy link
Contributor

mikeage commented Oct 19, 2018

The Dockerfile just says alpine:latest, and installs python3. This will break at some point, probably rather soon :-)

I'll try to take a look at this some time next week, and see if I can't resolve any issues. [it'd also probably be a good idea to update some of the packages from requirements.txt, as the versions there are a bit old]. That is, unless someone else wants to do it first!

@fergyfresh
Copy link
Collaborator

fergyfresh commented Oct 19, 2018 via email

@mikeage
Copy link
Contributor

mikeage commented Oct 19, 2018

Totally unrelated, but would you mind a PR that runs the entire project through autopep8? My editor keeps wanting to do it anyway, but I don't want to submit formatting changes at the same time as functional changes, but I keep having to undo it's "helpful" changes :-)

@fergyfresh
Copy link
Collaborator

fergyfresh commented Oct 19, 2018 via email

@mikeage
Copy link
Contributor

mikeage commented Oct 19, 2018

ok. I personally hate them :-)

In any case, autopep8 coming right up.

@fergyfresh
Copy link
Collaborator

fergyfresh commented Oct 19, 2018 via email

@mikeage
Copy link
Contributor

mikeage commented Oct 20, 2018

@darryllee , can you explain a bit more about the issue(s) you saw? I just did a pip install on my Macbook (it's not internet facing, and so I didn't do anything more than run the server to confirm that it ran -- I can't run ngrok on it due to a corporate security issue), and I faced the following issues, but I want to make sure your cases are all covered:

I also tested under alpine (using python:3.7-alpine instead of the alpine image), and it worked there as well with the current Dockerfile (well, after I changed the packages around a bit to remove some unnecessary stuff), without any extra changes.

@darryllee
Copy link
Author

If I remember correctly, downgrading pip got me a little further. But then for some reason I needed to rebuild cryptography, and I ran into this: pyca/cryptography#3489

@mikeage
Copy link
Contributor

mikeage commented Oct 21, 2018

Ok, thanks. That fits with what I saw. The reason, btw, is that cryptography is a bit of a bit to compile, and so most people use the wheel which is pre-compiled, but the version of cryptograhy in requirements.txt doesn't include a python 3.7 compliant wheel. Can I ask you to try PR #259 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants