Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline events should use dates to order rather than rely on their position in an array. #138

Open
CodeSpent opened this issue Feb 20, 2022 · 3 comments

Comments

@CodeSpent
Copy link

Considering this component acts as a timeline and date ranges are provided, this could be used for sorting the timeline elements in chronological order.

I was able to get this working in my own project, and will look at opening a PR for this.

@joejcox
Copy link

joejcox commented Feb 27, 2023

I think this would be good as an optional configuration, but it should also be able to sort by the original position in array.

@stephane-monnot
Copy link
Owner

I think this would be better to sort outside the component, in javascript on client side before passing props to Timeline component or on server side.

@clbenoit
Copy link

clbenoit commented Feb 6, 2024

What would happen if the dates overlapped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants