Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all .env variables into docker-compose.yml #46

Open
MicahZoltu opened this issue Oct 15, 2024 · 0 comments
Open

Move all .env variables into docker-compose.yml #46

MicahZoltu opened this issue Oct 15, 2024 · 0 comments

Comments

@MicahZoltu
Copy link
Contributor

While Docker does support config files, it is often undesireable to have configuration in two places (docker-compose and .env). For the docker-compose instructions, all of the necessary environment variables and their comments should be migrated to the docker-compose file, and the instructions updated to explain how to set them. It may be worth making a note which environment variables can be read from a .env file for those who prefer that method for configuration.

Importantly, if all configuration is read from the compose file, then you can publish a pre-built image to Docker Hub or GitHub image repository and users would no longer need to clone the repository to get OpenCast working in Docker. They would merely need to copy/paste the docker-compose.yml file into their management software or a file on their desktop. The inclusion of the .env creates a requirement to build from source, which is unfortunate for many users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant