Rename soroban-rpc to stellar-rpc #644
Conversation
There was a problem hiding this comment.
Couple minor things. It also looks like builds are failing so maybe something else in there needs tweaking to fix that.
The builds are failing with:
ERROR: failed to solve: failed to read dockerfile: open cmd/stellar-rpc/docker/Dockerfile: no such file or directory
|
@leighmcculloch PTAL |
.github/workflows/build-latest.yml
Outdated
| stellar_rpc_ref: v22.1.0 | ||
| stellar_rpc_ref: fb9f8c7c146485e0d4f7e4285e62e1678c89ce3d |
There was a problem hiding this comment.
Can a version of stellar-rpc be released for quickstart to reference?
While it functionally works to ref the git commit, that's intended to be used for dev and testing or in PRs. When users look at what version is in use, it won't report a released version. The testnet tag is reserved for rc and stable releases, and the latest tag is reserved for stable releases.
There was a problem hiding this comment.
I don't think it's worth going through the hassle of releasing just for this. It will get updated to a stable tag in the next release.
There was a problem hiding this comment.
If it's not worth releasing rpc with the new name, whats the motivation for breaking out of the regular process, and releasing a special unreleased version into QuickStart now rather than updating it at the rpc next stable release?
There was a problem hiding this comment.
Because QuickStart will be broken without the update and we need it for system tests and finish the renaming. See stellar/system-test#107
There was a problem hiding this comment.
I would agree that quickstart should only have released versions referenced here.
There was a problem hiding this comment.
CI is broken in stellar-rpc because of this
There was a problem hiding this comment.
The CI that's broken, can you update it to point to this PR? This PR is published to: stellar/quickstart:pr644-v459-latest.
There was a problem hiding this comment.
OK, I will give that a try
There was a problem hiding this comment.
Can you take a look at stellar/system-test#107 ?
No description provided.