Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANCHOR-860] Bump java-stellar-sdk version #1555

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[ANCHOR-860] Bump java-stellar-sdk version #1555

wants to merge 3 commits into from

Conversation

JiahuiWho
Copy link
Contributor

philipliu
philipliu reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 0.44.0 support Protocol 22? It looks like this is the first version to do so.

...src/test/kotlin/org/stellar/anchor/platform/custody/fireblocks/FireblocksEventServiceTest.kt Outdated
@@ -245,7 +245,7 @@ class FireblocksEventServiceTest {
} returns null

eventsService.handleEvent(eventObject, httpHeaders)

println(gson.toJson(paymentCapture.captured))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: println

@JiahuiWho JiahuiWho marked this pull request as ready for review October 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipliu philipliu philipliu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiahuiWho @philipliu