Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action to generate GIFs for all datasets/shapes when someone adds a new one in a PR #217

Closed
stefmolin opened this issue Sep 23, 2024 · 2 comments · Fixed by #222
Closed

Add GitHub Action to generate GIFs for all datasets/shapes when someone adds a new one in a PR #217

stefmolin opened this issue Sep 23, 2024 · 2 comments · Fixed by #222
Assignees
@JohnAZoidberg
Labels
ci/cd Relating to local development or CI/CD enhancement New feature or request
Milestone
0.3.0

Comments

@stefmolin
Copy link
Owner

Is your feature request related to a problem? Please describe.
When testing a new dataset or shape that someone proposes, I have to run the transformations on every possible combination with that shape or dataset.

Describe the solution you'd like
I would like to have a GitHub Action that only runs when a new dataset or shape is added and creates an artifact with all of the GIFs that I can review.

Additional context
A good starting point would be to enable passing all as a dataset (data-morph --start-shape all).
@JohnAZoidberg
Copy link
Contributor

/take

@stefmolin stefmolin added this to the 0.3.0 milestone Sep 23, 2024
@stefmolin stefmolin added ci/cd Relating to local development or CI/CD enhancement New feature or request labels Sep 23, 2024
@JohnAZoidberg
Copy link
Contributor

JohnAZoidberg commented Sep 23, 2024 •
edited
Loading

Goal:

  • Generate morphs
    • Run one morph if core code changed
    • Run 1 to N if dataset added or changed
    • Run N to 1 if shape added or changed
  • Upload as GH actions artifact
  • Upload as a comment on the PR

@JohnAZoidberg JohnAZoidberg mentioned this issue Sep 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnAZoidberg JohnAZoidberg

Labels
ci/cd Relating to local development or CI/CD enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

gh-actions: Build and upload all artifacts JohnAZoidberg/data-morph
2 participants
@JohnAZoidberg @stefmolin