Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNAME DMARC not working #29

Open
donserdal opened this issue May 14, 2024 · 1 comment
Open

CNAME DMARC not working #29

donserdal opened this issue May 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@donserdal
Copy link

donserdal commented May 14, 2024

Describe the bug
When checking a domain with a CNAME'd There is a Go Panic regarding

To Reproduce
Check a domain with a CNAME'd DMARC record
Can be created using: https://mxtoolbox.com/dmarc/dmarc-setup-cname

Expected behavior
DMARC report :-D

Screenshots
user@server:~$ mxcheck -n -s < REDACTED >.nl -S default

INFO: 2024/05/14 15:24:50 == Checking: < REDACTED >.nl ==
INFO: 2024/05/14 15:24:50 Found MX:
INFO: 2024/05/14 15:24:50 < REDACTED >-nl.mail.protection.outlook.com.
INFO: 2024/05/14 15:24:50 == Checking DKIM record ==
INFO: 2024/05/14 15:24:50 DKIM not set or wrong selector
INFO: 2024/05/14 15:24:50 == Checking DMARC record ==
panic: interface conversion: dns.RR is *dns.CNAME, not *dns.TXT

goroutine 1 [running]:
main.getDMARC({0x7fff3566f5fd?, 0xc0000c95d8?}, {0x70ad2f, 0x7})
/home/user/go/pkg/mod/github.com/steffenfritz/[email protected]/dns.go:245 +0x3cc
main.main()
/home/user/go/pkg/mod/github.com/steffenfritz/[email protected]/main.go:167 +0xd56

System (please complete the following information):

  • OS: Ubuntu
  • Version 22.04
@steffenfritz steffenfritz added the bug Something isn't working label May 14, 2024
@steffenfritz
Copy link
Owner

steffenfritz commented May 14, 2024

Hi,

the check is done against a TXT entry and not CNAME, this has to be handled and therefore I added the bug label.

However, in your report snippet I see "DKIM not set or wrong selector". Can you redo the test with the correct selector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants