Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View / Collapse Doesn't Work with 2 Pinned Posts #3929

Open
the-gorilla-steem opened this issue Nov 26, 2024 · 1 comment
Open

View / Collapse Doesn't Work with 2 Pinned Posts #3929

the-gorilla-steem opened this issue Nov 26, 2024 · 1 comment

Comments

@the-gorilla-steem
Copy link
Contributor

When there are 2 pinned posts on the page (e.g. https://steemit.com/trending/hive-146118), the view / collapse pinned posts doesn't change the layout.

deutsch-unplugged
the-gorilla-steem added a commit to the-gorilla-steem/condenser that referenced this issue Nov 28, 2024
@the-gorilla-steem
Bug Fix
e879072 
Fixed bug steemit#3929 (View / Collapse Doesn't Work with 2 Pinned Posts)
@only-dev-time
Copy link
Contributor

Bug fixed with this commit.

ety001 pushed a commit that referenced this issue Dec 20, 2024
@the-gorilla-steem
#proposal 86 hide resteems (#3930)
ec88f73 
* Bug Fix

Fixed bug #3929 (View / Collapse Doesn't Work with 2 Pinned Posts)

* Implemented Resteems

In combination with bug fix commit - this is the remaining code to implement the hiding of Resteems within a Feed.

* Community Banner Display

Improved the display of the community banner on mobile devices for the following scenarios:
* A community with a large number of subscribers and/or large pending rewards
* A community with a long description

* Hide Resteems Translations

Introduced translations for the "Hide Resteems" label as well as removing comments used whilst debugging.

* Other Friends Feed

Adjusted how the feed being viewed is determined.

* Minor Display Updates

1. Adjusted the colours of the "Next" and "Back" button so that they adjust with the theme (light / dark mode).
2. Tweaked the display of subscribers, pending rewards and active authors on mobile devices so that figures > 10,000 use 10k, 1m, etc. and 1 decimal place.

* Alignment Improvements

Adjusted the positioning and spacing around the "Hide Resteems" button to make it look nicer on mobile and desktop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@the-gorilla-steem @only-dev-time