Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting .develop log level to default to reporting to Sentry #44

Open
steamclock-bot opened this issue Feb 12, 2021 · 3 comments

Comments

@steamclock-bot
Copy link

Automatically generated from steamclock/steamclog-swift#82

I'm not sure why we decided against this originally, but since we're able to determine which build a report comes from in Sentry this seems like it makes sense to me?

@ssawchenko ssawchenko assigned jacobminer and unassigned jacobminer Aug 16, 2021
@ssawchenko ssawchenko self-assigned this Sep 10, 2021
@ssawchenko
Copy link
Collaborator

ssawchenko commented Sep 10, 2021

Given Sentry limits it seems risky to default debug builds to send Sentry reports. Even after our TechWG discussion we did not change the LogLevel presets to allow for this. Right now there is no way for us to manually change only the remote logging level, but we could look at adding the ability to enable it.

Some ways we could support this:

  1. Add a custom LogLevelPreset, where the caller indicates the exact levels they want:
class Custom(val consoleLogLevel: LogLevel, val diskLogLevel: LogLevel, val remoteLogLevel: LogLevel): LogLevelPreset()
  1. Make the remote level mutable so that the calling application can modify only it

@ssawchenko
Copy link
Collaborator

I think we can leave this as an advanced feature for 2.1.

@ssawchenko
Copy link
Collaborator

Personally I see no reason why we cannot go ahead with adding the Custom preset option in 2.1. This seems like it would be useful in development environments when we need complete control over how we are logging.

@ssawchenko ssawchenko removed their assignment Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants