Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompose ContactDetails into smaller, flexible components #16793

Open
micieslak opened this issue Nov 21, 2024 · 0 comments
Open

Decompose ContactDetails into smaller, flexible components #16793

micieslak opened this issue Nov 21, 2024 · 0 comments
Assignees
@micieslak
Labels
bug Something isn't working goal:core:P0:no_critical_or_high_regressions

Comments

@micieslak
Copy link
Member

Description

Currently ContactDetails takes contact store and profile store to uniformly provide details for contacts, from the model and own profile. It means that components accessing contacts via ContactDetails become dependent on those two stores. However in some cases it's not necessary, and lighter container for contact details would be useful (e.g. preview of own profile).

The idea is to split ContactDetails into 3 elements:

  • adaptor adding own profile to arbitrary contacts model
  • wrapper over ModelEntry customized for contact details
  • lightweight pod componet, aggregating contact details properties
@micieslak micieslak added the bug Something isn't working label Nov 21, 2024
@micieslak micieslak self-assigned this Nov 21, 2024
@micieslak micieslak moved this to In Progress in Status Desktop/Mobile Board Nov 21, 2024
micieslak added a commit that referenced this issue Nov 21, 2024
@micieslak
ContactDetails decomposed into smaller, more specialized components
a2bdcfb 
Closes: #16793
@micieslak micieslak mentioned this issue Nov 21, 2024
Open
1 task
@micieslak micieslak changed the title Decompose ContactDetails into modular subcomponents Decompose ContactDetails into smaller, flexible components Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micieslak micieslak

Labels
bug Something isn't working goal:core:P0:no_critical_or_high_regressions
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micieslak