624 recent updates feed on main page #626
Conversation
| /** | ||
| * Store a newly created resource in storage. | ||
| */ | ||
| public function store(Request $request) |
There was a problem hiding this comment.
If you already have a create method you don't need store, this method can be deleted.
| /** | ||
| * Display the specified resource. | ||
| */ | ||
| public function show(Treet $treet) |
There was a problem hiding this comment.
show is a method that fetches one instance of the model. For example, clicking on a blog post title to view the full post. Since we don't need such a method in this context, this can be deleted.
| /** | ||
| * Show the form for editing the specified resource. | ||
| */ | ||
| public function edit(Treet $treet) |
There was a problem hiding this comment.
It would be nice to be able to edit, but it's not too important at the moment, since we have database access if we really need to edit the text. This method can be deleted.
| /** | ||
| * Update the specified resource in storage. | ||
| */ | ||
| public function update(Request $request, Treet $treet) |
There was a problem hiding this comment.
You have a method for update and edit, I would expect those to both perform the same function. You really only need one, if any. Since we don't need this you can just delete this method.
| { | ||
| // | ||
| } | ||
| public function getTreetFeed(Request $request) |
There was a problem hiding this comment.
This code belongs in index(). On that note, take some time to learn about CRUD, a general design model. At a very basic level, the idea is that there are four basic operations we perform on data - Create, Read, Update, Delete. This means one method for each of those operations. In our apps we add one more, a method specifically for fetching multiple, and we call that index(). So, almost all of our controllers contain index(), show(), create(), update(), and delete(). Some purists even argue that if you need more methods than that per controller, you need to refactor! I think that's very extreme. But following the model, most of the time, is helpful I think.
|
Looking very good! Just a few notes:
|
Updating web to include the new ash survey fields