Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp in spike watch output #77

Open
utx0 opened this issue Oct 27, 2017 · 5 comments
Open

Timestamp in spike watch output #77

utx0 opened this issue Oct 27, 2017 · 5 comments

Comments

@utx0
Copy link

utx0 commented Oct 27, 2017

Be great to have a timestamp in the spike watch output.

Am just starting to get my hands dirty converting a html theme to a spike site and am finding myself while debugging this process never quite sure if/when the compiler has run.

If you guys are open to this enhancement i'll have a crack at adding it if you want?

@jescalan
Copy link
Member

jescalan commented Nov 6, 2017

Sure, would love to have that feature! I think it would be a great first time contributor feature as well. Let me know if you need help!

@jescalan
Copy link
Member

Just following up on this one!

@utx0
Copy link
Author

utx0 commented Dec 15, 2017 via email

@adamkiss
Copy link

adamkiss commented Mar 31, 2018

@jescalan I could tackle this - I'm using a fork of spike with ^HEAD spike-core where I already added it, albeit hard-coded, and I could use some sort of direction. I'd also like to add a 'this file changed, rebuilding…' to watcher - I have already figured it out how, and I'm adding it here as it's also under the umbrella of 'verbosity'

The timestamp

The timestamp is/should be added to spike/bin/cli.js, but where should the config value come in from? As far as I can see, there is no config values going from app.js to cli, only e.g. port settings overriding app.js?

The watcher - file changed

This one needs three components - webpack hook, some sort of spike <=> cli emit function, and also should read some config from somewhere. I ~have the webpack hook figured out, but I am not sure where to add it. Possibly spike-core/plugin.js?

Thanks

@jescalan
Copy link
Member

jescalan commented Apr 2, 2018

Hey @adamkiss! I think probably the best way for me to work through this with you, to be honest, would be to jump on a video call for like an hour and just talk it through. I have been really overloaded with work these days, so the best way for me to keep my attention in one place is to set up a specific date/time to handle it. Want to shoot me a time on slack that's good for you and maybe we can just hammer it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants