Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for enabling/disabling "Enable UID" (P2P) #91

Open
Daluqen opened this issue Nov 26, 2024 · 4 comments
Open

Support for enabling/disabling "Enable UID" (P2P) #91

Daluqen opened this issue Nov 26, 2024 · 4 comments

Comments

@Daluqen
Copy link

Daluqen commented Nov 26, 2024

I wanted to check if it’s possible to add support for turning P2P on and off for the NVR and making that accessible in Home Assistant. I'd like to keep it off most of the time, but it would be handy to turn it on temporarily when I want to check the camera playback.

I saw that there’s already a getter for this command: reolink_aio/api.py#L3527, so it looks like we’d just need a setter for it.

Is this something could be implemented and exposed to HA?

Thanks a lot for all your great work!

@starkillerOG
Copy link
Owner

It can definitely be done, I am just thinking about if it would be wise to add it.

In my opinion its more of a "set it once and never touch it again" setting.

Moreover if people accidently turn it off, it will break the remote acces to their cams in the Reolink app. And I don't know what happens to the UID string when turning it off. If that changes HomeAssistant is screwed since it uses that as unique ID for everything.

@starkillerOG
Copy link
Owner

Let me think a bit about this.

@Daluqen
Copy link
Author

Daluqen commented Nov 26, 2024

I enabled/disabled that in a reolink web app and it didn't break home assistant integration.

Edit: Verified and changing p2p, does not change UID of the cameras in the reolink.

@Daluqen
Copy link
Author

Daluqen commented Nov 26, 2024

Meanwhile I can create http request action on home assistant to do set it manually:

[
    {
        "cmd": "SetP2p",
        "param": {
            "P2p": {
                "enable": 1
            }
        }
    }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants