Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractTableDataSource.swift line 182 assert not needed #52

Open
lukasz-lenkiewicz opened this issue Apr 24, 2019 · 2 comments
Open

AbstractTableDataSource.swift line 182 assert not needed #52

lukasz-lenkiewicz opened this issue Apr 24, 2019 · 2 comments
Assignees

Comments

@lukasz-lenkiewicz
Copy link
Contributor

The assert in AbstractTableDataSource.swift line 182 is actually not that good. I just had a case when 1 screen is reusing generic uitableviewcell and this screen doesnt need any delegate. Atm app is crashes as this screen is not setting delegate. This should be optional IMHO.

@talezion
Copy link
Contributor

talezion commented Jul 9, 2019

@lukasz-lenkiewicz The assert is important. It will only crash on dev/stage. How would you solve it if you forgot to set a delegate?

@lukasz-lenkiewicz
Copy link
Contributor Author

lukasz-lenkiewicz commented Jul 9, 2019

@talezion delegate should be optional - every delegate in iOS is optional :) If its mandatory, it should be part of the init method so we can avoid cases i had (in the description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants