New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long lines make code hard to review #13

Closed

dkegel-fastly opened this issue Nov 13, 2022 · 1 comment · May be fixed by #14

dkegel-fastly commented Nov 13, 2022

Although DSVW is indeed small, calling it 100 lines of code might be a stretch, as it uses extremely long lines to achieve this.

The long lines are hard to understand and review.

This is a security problem; attacks mentioned in https://blog.phylum.io/phylum-discovers-dozens-more-pypi-packages-attempting-to-deliver-w4sp-stealer-in-ongoing-supply-chain-attack relied on long lines to evade review.

autopep8 helps a little, but really, the code should be run through Black, which turns it into 500 lines of much more readable python.

dkegel-fastly mentioned this issue

Format with Black, use one line per import #14

Open

stamparm closed this as completed

Owner

stamparm commented Nov 14, 2022

security problem :)

Repository owner locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.