Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting out the tunnel directory into a separate module #14

Open
arj03 opened this issue Sep 12, 2020 · 2 comments
Open

Splitting out the tunnel directory into a separate module #14

arj03 opened this issue Sep 12, 2020 · 2 comments

Comments

@arj03
Copy link

arj03 commented Sep 12, 2020

Trying to add this as a module to ssb-browser I see that a lot of stuff is pulled in (like ssb-master). I was wondering if it would make sense to split out the actual implementation into maybe two modules? ssb-room-server and ssb-room-client?

@staltz
Copy link
Owner

staltz commented Sep 12, 2020

ssb-room-server and ssb-room-client?

Agree. But just to clarify, you're talking specifically about ./tunnel/server.js and ./tunnel/client.js, right? This module ssb-room requires ssb-master because it has all the other things for running the server. In other words, this module is not really a simple SSB plugin, it is bundling a bunch of things. And it should, as you said, be implemented more granularly.

@arj03
Copy link
Author

arj03 commented Sep 12, 2020

Yes, and probably also utils.js into its own module. Still learning here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants