Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADR on CRD versioning #273

Closed
3 tasks
soenkeliebau opened this issue Sep 9, 2022 · 3 comments
Closed
3 tasks

Create ADR on CRD versioning #273

soenkeliebau opened this issue Sep 9, 2022 · 3 comments

Comments

@soenkeliebau
Copy link
Member

We do not currently version our CRDs in a proper fashion, but rather just yolo changes.

This is something that we urgently need to change and introduce proper versions for all our CRDs. However I believe that this requires us to provide conversion functions and controllers to run these functions, which makes this a somewhat larger issue than just updating the version in our CRDs.

This ticket is done when:

  • An ADR was written and accepted that details what needs to be done and outlines the options
  • An option was chosen
  • Appropriate follow up tickets for the chosen option have been created
@nightkr
Copy link
Member

nightkr commented Sep 14, 2022

Yes, we need this. No, this doesn't have anything whatsoever to do with how Helm deploys the CRDs. To quote the docs:

There is no support at this time for upgrading or deleting CRDs using Helm.

@soenkeliebau
Copy link
Member Author

There is no support at this time for upgrading or deleting CRDs using Helm.

Fuck

@fhennig
Copy link
Contributor

fhennig commented Jan 29, 2024

There is now an epic: stackabletech/issues#507

I'm closing this in favor of the epic (which also links to a different ADR ticket)

@fhennig fhennig closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants