Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is home on terms archive endpoint when there are no terms #12

Open
ssnepenthe opened this issue Oct 23, 2017 · 0 comments
Open

Is home on terms archive endpoint when there are no terms #12

ssnepenthe opened this issue Oct 23, 2017 · 0 comments

Comments

@ssnepenthe
Copy link
Owner

To determine if current page is terms archive one of the checks is whether the current page query returns any terms.

If there are no terms, is_terms_archive() will return false which means 404 isn't preempted and main query isn't squashed.

Additionally, many template tags (like have_terms()) wont work b/c they first check is_terms_archive().

I think it is as simple as removing the check 1 > count( $this->loop->get_terms() ) in the endpoints class but needs more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant