Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publicAccessControl #242

Open
sshivaditya2019 opened this issue Dec 12, 2024 · 1 comment
Open

Refactor publicAccessControl #242

sshivaditya2019 opened this issue Dec 12, 2024 · 1 comment

Comments

@sshivaditya2019
Copy link
Owner

sshivaditya2019 commented Dec 12, 2024

I realize that contributors cant add labels unless there is an issue template that allows them to create an issue and select labels when creating issues, but this is an unusual scenario that projects need to go out of their way for.1234

Remove all references to publicAccessControl.setLabel
Refactor publicAccessControl to only be a boolean called: fundContributorClosedIssue, default is false.5
https://www.github.com/ubiquity-os-marketplace/assistive-pricing/blob/9984131a66eb9167dd0f60147a99e41ae382c43b/src/types/plugin-input.ts#L23-L29

Note
The reason why fundContributorClosedIssue exists is because if:

an outside party files an issue
we fund it
self assign
Then they can mark the issue closed as completed using the GitHub UI (because they created the issue) which makes an easy attack vector.

Footnotes

  1. ⚠ 79% possible duplicate - Feature Request: Dark Mode for UI

  2. ⚠ 79% possible duplicate - Feature Request: Dark Mode for UI

  3. ⚠ 78% possible duplicate - Issue with Account Access

  4. ⚠ 78% possible duplicate - Data Upload Takes Too Long

  5. ⚠ 78% possible duplicate - File upload fails always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant