Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix members tangle calculation when reset on new epochs #69

Closed
Powersource opened this issue Mar 15, 2023 · 1 comment · Fixed by #75
Closed

Fix members tangle calculation when reset on new epochs #69

Powersource opened this issue Mar 15, 2023 · 1 comment · Fixed by #75
Assignees
Labels
should Needed in production

Comments

@Powersource
Copy link
Collaborator

Needed if things end up like suggested here ssbc/ssb-group-exclusion-spec#17 (comment)

@Powersource Powersource changed the title Fix member tangle calculation when reset on new epochs Fix members tangle calculation when reset on new epochs Mar 15, 2023
@Powersource Powersource added the should Needed in production label Mar 15, 2023
@Powersource
Copy link
Collaborator Author

Powersource commented Mar 15, 2023

Maybe we could extract the getGroupInfo out of https://github.com/ssbc/ssb-tribes2/blob/master/lib/get-tangle.js and move it into https://github.com/ssbc/ssb-tribes2/blob/master/lib/add-tangles.js Then we could pass different roots in as arguments into the different GetTangles. Then get-tangle.js could be kept/made even more generic. Initially we could maybe just calculate the epoch root. If that turns out to be slow then we could maybe store it in the keyring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
should Needed in production
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant