Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after updating can no longer call commands on sbot/ssb-server without an error #647

Closed
frankiebee opened this issue Mar 13, 2019 · 19 comments
Labels

Comments

@frankiebee
Copy link

frankiebee commented Mar 13, 2019

after updating can no longer call comands on sbot/ssb-server without an error
error: Cannot read property 'apply' of undefined

node -v
v10.11.0
npm -v
6.4.1

repro:

  • start patchbay or ssb-server
  • open new tab in terminal
  • > ssb-server --help || sbot --help
@frankiebee
Copy link
Author

oooh was help removed?

@frankiebee
Copy link
Author

on that note to how do i install plugins now?

@frankiebee frankiebee changed the title after updating can no longer call comands on sbot/ssb-server without an error frankie has issues Mar 13, 2019
@frankiebee
Copy link
Author

new node version also means node_modules in .ssb needed to be rebubilt
sense a rebuild failed
ive just decided to reinstall plugins
but well i'm hitting a idk how to do that anymore sense it seems thats no longer an option from sbot

@frankiebee
Copy link
Author

semi solution / frankie is insane 😅

i removed node modules and turned off all my plugins and am not starting sbot outside of patchbay

ux issue: always takes me about an hour or 2 to update sbot i think last time i just nuked everything and resynced my whole feed but at that time i knew how to install plugins

this most likely isnt a problem with sbot and is more around node but i'm sure some of this could be avoided

@dominictarr
Copy link
Contributor

to rebuild plugins: cd ~/.ssb && npm rebuild

sbot plugins.install <plugin_name> still works.
but in my opinion, we should probably remove npm from sbot... you can also install a plugin manually by doing cd ~/.ssb && npm install <plugin> and then editing ~/.ssb/config so that "plugins": {"<module_name>": true},

@frankiebee
Copy link
Author

so @dominictarr rebuild failed and sbot dosent seem to know plugins.install

i get:

Command not found: plugins.install
Cannot read property 'apply' of undefined

@frankiebee frankiebee changed the title frankie has issues after updating can no longer call commands on sbot/ssb-server without an error Mar 13, 2019
@dominictarr
Copy link
Contributor

weird... what version of ssb-server did you install? I'm using 14.1.7
oh what it might be: if you are running patchbay's sbot, they might not have plugins.
check ~/.ssb/manifest.json and see if it has a plugins section.

@frankiebee
Copy link
Author

frankiebee commented Mar 13, 2019

oh what it might be: if you are running patchbay's sbot, they might not have plugins.

yeah okay running my outside of patchbay works for plugins

but --help is no longer an option in the update?

@frankiebee
Copy link
Author

sbot version
"19.1.0"

@dominictarr
Copy link
Contributor

Hmm, oh that is the ssb-db version, not the ssb-server version... oh now I see what happened. We moved the code that was in ssb-server into ssb-db so now it reports that version!

that should probably the versions of all the plugins, anyway!

@dominictarr
Copy link
Contributor

@frankiebee how did you do install ssb-server, did you do npm install ssb-server -g or is it the one that's inside of patchbay?

@dominictarr
Copy link
Contributor

or did you git clone it then install?

@frankiebee
Copy link
Author

npm install ssb-server -g

@frankiebee
Copy link
Author

should i be git cloneing it?

@dominictarr
Copy link
Contributor

my hunch is that you are hitting the sbot that is bundled inside of patchbay, that doesn't use plugins which would explain why you are not getting any.

@dominictarr
Copy link
Contributor

we really should have a better way to detect what plugins are running.

@frankiebee
Copy link
Author

when i'm only using my sbot and not running patch bay i still dont get the --help so i dont know my options here

@dominictarr
Copy link
Contributor

issue for reinstating help text and version numbers: #648

@stale
Copy link

stale bot commented Jun 20, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale label Jun 20, 2019
@stale stale bot closed this as completed Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants