New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify findByIdSync #80

Closed

Powersource opened this issue Sep 26, 2022 · 1 comment · Fixed by #69

Collaborator

Powersource commented Sep 26, 2022

When reading the docs

sbot.metafeeds.findByIdSync(feedId)

Similar to findById, but returns synchronously. warning Note, in order to use this API, you must call sbot.metafeeds.loadState(cb) first, and wait for cb to be called.

It's a bit unclear if I just have to had called loadState at some point, or if i have to call it immediately before findByIdSync, every time.

Member

staltz commented Sep 26, 2022

I think we can remove this from readme because the functions were also deleted, is I remember correctly

staltz linked a pull request

that will close this issue

Merged

staltz closed this as completed in #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment