Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branchstream with root doesn't seem to work #114

Open
arj03 opened this issue Jan 29, 2023 · 2 comments · May be fixed by #122
Open

branchstream with root doesn't seem to work #114

arj03 opened this issue Jan 29, 2023 · 2 comments · May be fixed by #122

Comments

@arj03
Copy link
Member

arj03 commented Jan 29, 2023

I'm trying to fix this unpin ssb-meta-feeds again in tribes2 and it seems that there is something wrong in branchstream when you pass it a root. This is also not tested as far as I can see. What I'm seeing is that is just returns your whole forest. Instead of just for that root. And this line looks wrong. It basically just tests that you have a seed yourself, not that it correspond to anything within the message.

Anyway this is a vague issue, just wanted to put it out there. I might not have time to look at it for a few days.
@arj03
Copy link
Member Author

arj03 commented Feb 12, 2023

Doesn't seem to be the issue

@arj03 arj03 closed this as completed Feb 12, 2023
@Powersource Powersource reopened this Apr 5, 2023
@Powersource Powersource linked a pull request Apr 5, 2023 that will close this issue
Draft
4 tasks
@Powersource
Copy link
Collaborator

made pr with failing test #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for branchStream root opt ssbc/ssb-meta-feeds
2 participants
@arj03 @Powersource