Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update box2 to 4.0 #414

Open
arj03 opened this issue Jan 16, 2023 · 3 comments
Open

Update box2 to 4.0 #414

arj03 opened this issue Jan 16, 2023 · 3 comments

Comments

@arj03
Copy link
Member

arj03 commented Jan 16, 2023

Makes it easier to work with tribes2.

@staltz
Copy link
Member

staltz commented Jan 17, 2023

@arj03 Since box2 is a dependency in ssb-db2, and box2 4.0 nowadays doesn't work unless you have ssb-meta-feeds, this means we have to make ssb-meta-feeds a dependency in ssb-db2, right?

It's a bit confusing, because ssb-db2 is a dependency in ssb-meta-feeds.

It would be easier if ssb-db2/index.js would be just a "distro" of ssb-db2, perhaps in a separate module ssb-db2-starter-kit (I'm not serious about this idea), then we would solve the dependency chicken-and-egg. As you said, the chicken-and-egg issue makes it hard to use some ssb-db2 in some projects. In fact, we also have the ssb-fixtures chicken-and-egg with db2.

@arj03
Copy link
Member Author

arj03 commented Jan 17, 2023

Yeah, I'm maybe more included to moving some of these things out of db2. Instead of the distro thing we could maybe just document it really well in the readme. Like, if you just want classic then include classic + box1. If you want "proper" box2 then include tribes, metafeeds and box etc.

@staltz
Copy link
Member

staltz commented Jan 17, 2023

Yeah, I sympathize with that plan.

And just a note, it would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants