Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nasty testing hack #33

Open
KyleMaas opened this issue Jan 24, 2023 · 2 comments
Open

Fix the nasty testing hack #33

KyleMaas opened this issue Jan 24, 2023 · 2 comments

Comments

@KyleMaas
Copy link

Why does this need to be here, and what would it take to eliminate it?

// NASTY TESTING HACK

It pops up in every (properly built) testing run of go-ssb.

@KyleMaas
Copy link
Author

At the very least, this should be turned into a DisableWriteCache() call or something similar rather than relying on an environmental variable.

@KyleMaas
Copy link
Author

And to clarify: I'm not asking what this does. I can see it tries to make writes fully synchronous so they're not cached. But if this system's buggy enough that go-ssb's testing suite needs this, and thus I assume all other downstream users of Margaret would need it to be reliably tested as well, then what bugs exist in the write queue and how do we fix them? That's what I mean by "why does this need to be here".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant