-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestSignMessages is flaky #289
Comments
We should really fix this TODO item as well: go-ssb/message/publish_test.go Line 89 in ab468b1
|
Ah, nope, we can't fix that one until #251 is fixed. It relies on the authors index being in sync with the main log immediately after publishing, and with no way to ensure that synchronization, that would be a good thing to test but it will currently fail. |
Filed as #290 so we can fix that later. |
Jeepers, this test is a mess of race conditions. It's a wonder it ever worked. The tests all rely on the author log being up-to-date with the main log. See: go-ssb/message/publish_test.go Line 98 in ab468b1
I think I might try and get this to test what it needs to without accessing the author feed. That way we can test the one thing this test is designed to test - make sure that messages are referencing each other properly when published. |
Ugh. Line 132 in ab468b1
|
Interestingly, the publish log seems to have a partial idea that the author log may be out of sync: Line 64 in ab468b1
|
Argh! This test doesn't use |
After a bunch of PASSes, two failures in a row:
The text was updated successfully, but these errors were encountered: