Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests after skip-ocalypse of #167 / #170 #169

Closed
decentral1se opened this issue Oct 18, 2022 · 3 comments
Closed

Re-enable tests after skip-ocalypse of #167 / #170 #169

decentral1se opened this issue Oct 18, 2022 · 3 comments
Labels
question Further information is requested testing

Comments

@decentral1se
Copy link
Member

decentral1se commented Oct 18, 2022 •
edited
Loading

re: #167 (comment)
re: #170
@decentral1se decentral1se changed the title Re-enable tests after skip-ocalypse of #167 Re-enable tests after skip-ocalypse of #167 / #170 Oct 21, 2022
@decentral1se decentral1se mentioned this issue Oct 23, 2022
Closed
@decentral1se
Copy link
Member Author

Some tests are still flaking with timeouts on https://github.com/ssbc/go-ssb/actions/runs/3335633917/jobs/5519830766 😢

I've seen a couple of deadlock fixes in planetary ssb fork which I'm gonna take a stab at backporting soon...

@decentral1se decentral1se mentioned this issue Nov 3, 2022
Closed
@decentral1se
Copy link
Member Author

re: https://github.com/ssbc/go-ssb/actions/runs/3386042898/jobs/5624937974

2022/11/03 13:26:51 [margaret/indexes/badger] overwrote batch limit 0
--- FAIL: TestPrivatePublish (0.07s)
    --- FAIL: TestPrivatePublish/gabby (0.02s)
        publish_test.go:88: 
            	Error Trace:	/home/runner/work/go-ssb/go-ssb/private/publish_test.go:88
            	Error:      	Should be true
            	Test:       	TestPrivatePublish/gabby
            	Messages:   	expected to get a message
FAIL
FAIL	github.com/ssbc/go-ssb/private	0.089s
FAIL
make: *** [Makefile:22: test] Error 1

Potentially one to skip if no time to investigate...

@decentral1se decentral1se added the question Further information is requested label Nov 9, 2022
This was referenced Nov 29, 2022
Open
Open
@decentral1se decentral1se moved this from Need Help to In Progress in 🚧 go-ssb maintenance 🚧 Dec 18, 2022
@decentral1se
Copy link
Member Author

Dupe of #237.

Repository owner moved this from In Progress to Done in 🚧 go-ssb maintenance 🚧 Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested testing
Projects
🚧 go-ssb maintenance 🚧
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@decentral1se