Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to save and load model weights/parameters #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added options to save and load model weights/parameters #3

wants to merge 1 commit into from

Conversation

comadan
Copy link

@comadan comadan commented Oct 2, 2014

Added options to the command line tool for saving the model weights/parameters w0, w, v. This way a trained model can be reused.

I've never done any c++ programming or used github really. I also only have a high level understanding of libFM. So there's a decent chance these changes are very wrong...

@srendle
Copy link
Owner

srendle commented Oct 4, 2014

Thanks for your contribution. I quickly scanned your code and it might work. However, using this code is likely to cause problems for other users. Your code only works correctly if the id-range and mapping in the training and test files is not changed (i.e. no new features, feature-id mapping should remain unchanged). Moreover, when running MCMC, it only recovers the last state of the chain. This might be unexpected for common users and might generate lots of questions.

I won't merge the code into the main branch because it might cause problems for inexperienced users. Users who are aware of the issues above can try your load/save code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants