Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log loss should be comuted in base e, not 10 #21

Open
erlendd opened this issue Sep 23, 2016 · 1 comment
Open

Log loss should be comuted in base e, not 10 #21

erlendd opened this issue Sep 23, 2016 · 1 comment

Comments

@erlendd
Copy link

erlendd commented Sep 23, 2016

In _evaluate_class the log loss computed uses base 10, it should be base e (natural log).
I.e.:
_loglikelihood -= m_log10(pll) + (1-m)_log10(1-pll);
should be,
_loglikelihood -= m_log(pll) + (1-m)_log(1-pll);

@yunyu-Mr
Copy link

Yes, you are right.

_loglikelihood -= m * std::log(pll) + (1-m) * std::log(1-pll);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants