Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defined constants instead of hardcoding magic numbers #16

Open
benmccann opened this issue May 14, 2016 · 0 comments
Open

Use defined constants instead of hardcoding magic numbers #16

benmccann opened this issue May 14, 2016 · 0 comments

Comments

@benmccann
Copy link

fm_learn_sgd_element.h and fm_learn_sgd_element_adapt_reg.h have code like if (task == 0) {.

fm_learn_sgd.h does this in a much cleaner way: if (task == TASK_REGRESSION ) {

These enum constants should be used throughout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benmccann