Refactor generation and update gensim.fasttext usage #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
irinakhismatullina
commented
Jun 21, 2019
irinakhismatullina
commented
- Support the last version of gensim Update gensim.fasttext usage #754
- Change generation hyperparameters
- Small optimizations (less edit distance calculations, less lookups in sets)
irinakhismatullina
force-pushed
the
generation
branch
4 times, most recently
from
8f092e0 to
56be812
Compare
zurk
suggested changes
Jun 24, 2019
irinakhismatullina
force-pushed
the
generation
branch
from
8cdebe3 to
75341c6
Compare
vmarkovtsev
requested changes
Jun 26, 2019
irinakhismatullina
force-pushed
the
generation
branch
from
66a0419 to
b2de727
Compare
|
CI :) |
irinakhismatullina
force-pushed
the
generation
branch
from
081a8b4 to
a7ba540
Compare
Signed-off-by: Irina <[email protected]>
Signed-off-by: Irina <[email protected]>
irinakhismatullina
force-pushed
the
generation
branch
from
a7ba540 to
5d47979
Compare
zurk
approved these changes
Jul 4, 2019
|
Vadim's feedback was addressed => merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.