Add GeneralReports.generate_reports() function #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Slavnov <[email protected]>
vmarkovtsev
approved these changes
Mar 8, 2019
| def wrapped_capture_quality_report(*args, **kwargs): | ||
| if getattr(report, name) is not None: | ||
| raise RuntimeError("%s should be called only one time." % func.__name__) | ||
| def wrapped_capture_quality_reports(*args, **kwargs): |
There was a problem hiding this comment.
One day we should remove this function patching at all
There was a problem hiding this comment.
I also do not like it.
If we found any way to access comments from lookout-sdk without parsing logs we can easily remove this decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for the issue: #658
PR priority: low.
There are a lot of things to improve in our report generation system. When my main issue was blocked I refactor 1 thing: possibility to generate as many reports as you want with
GeneralReportclass. Before it was hardcoded to train, test and model reports.Logic is unchanged. Just one minor thing: Model report generated only in
aggregatemode.make report-qualitylogic completely the same.