Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only source{d} palettes #309

Open
dpordomingo opened this issue Oct 21, 2019 · 2 comments
Open

Show only source{d} palettes #309

dpordomingo opened this issue Oct 21, 2019 · 2 comments
Labels
enhancement New feature or request product-design Visual, branding, typography triage/needs-product-input This needs input from product

Comments

@dpordomingo
Copy link
Contributor

With #259 we added source{d} palettes, but we kept the ones offered by Apache Superset .

In order to let the user easily choose between our official palettes, it would be easier if the old superset palettes would not be there.

@dpordomingo dpordomingo added the enhancement New feature or request label Oct 21, 2019
@se7entyse7en se7entyse7en added product-design Visual, branding, typography triage/needs-product-input This needs input from product labels Oct 22, 2019
@marnovo
Copy link
Member

marnovo commented Oct 22, 2019

@dpordomingo at this point it's more harm than good: we have to make a change and removing a degree of freedom from our users—which could for example using telemetry later on give cues that users dislike our palette or that they want to customize to their own brand colors, for example. If our palettes are already the default + top choices, there's little benefit to the cost.

@dpordomingo
Copy link
Contributor Author

source{d} palettes are not the first ones, but added at the end of Apache Superset original ones.
Also, the users cannot add or customize their palettes, no matter we keep the original ones or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request product-design Visual, branding, typography triage/needs-product-input This needs input from product
Projects
None yet
Development

No branches or pull requests

3 participants