Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SQL Lab results table horizontal scroll #262

Open
carlosms opened this issue Aug 19, 2019 · 2 comments
Open

Change SQL Lab results table horizontal scroll #262

carlosms opened this issue Aug 19, 2019 · 2 comments
Labels
enhancement New feature or request product-design Visual, branding, typography triage/needs-product-input This needs input from product

Comments

@carlosms
Copy link
Contributor

Proposal, originally suggested by @dpordomingo here:

Could we fit the displayed columns in the window avoiding the horizontal scroll?
It could be done shrinking wider columns (like blob_content) using max-width or similar, and ellipsing it's content.

As I said in the original thread:

I think this is risky, we'll improve the experience for some results, but it may be worse in other cases.
Also the more we deviate from upstream, the more debt we accumulate to be paid when we need to merge newer code later.

My preference would be to wait for a stronger need to make changes like this.

@smacker
Copy link
Contributor

smacker commented Aug 19, 2019

ellipsing its content

Working on demos I used sqllab and ability to see the full content of a cell was very useful. (like commit hashes, long names and so on). Please don't break it.

@dpordomingo
Copy link
Contributor

Nice features:

  • a toggle to ellipse and unellipse, being the ellipsed version the default, and remembering the last user action.
  • being able to see the full content on hover.

@se7entyse7en se7entyse7en added enhancement New feature or request product-design Visual, branding, typography triage/needs-product-input This needs input from product labels Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request product-design Visual, branding, typography triage/needs-product-input This needs input from product
Projects
None yet
Development

No branches or pull requests

4 participants