Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid repeating hard-coded values for different containers #62

Open
smacker opened this issue Jun 19, 2019 · 2 comments
Open

Avoid repeating hard-coded values for different containers #62

smacker opened this issue Jun 19, 2019 · 2 comments
Labels
enhancement New feature or request needs more info Further information from author of issue is requested

Comments

@smacker
Copy link
Contributor

smacker commented Jun 19, 2019

One of the solutions might be to use env vars.
Related discussion: #54 (comment)
@smacker smacker mentioned this issue Jun 19, 2019
Merged
@se7entyse7en
Copy link
Contributor

This is old, I think this has been fixed using anchors.

@se7entyse7en se7entyse7en added enhancement New feature or request needs more info Further information from author of issue is requested labels Oct 24, 2019
@dpordomingo
Copy link
Contributor

Nope.
The requirement was about to use named env vars to signify the constraints between the same data in different containers,

e.g. to use ${METADATA_DB_NAME-metadata} instead of the same hardcoded metadata in:

keys in
x-superset-env.METADATA_DB docker-compose.yml#L22
ghsync.GHSYNC_POSTGRES_DB docker-compose.yml#L74
metadatadb.POSTGRES_DB docker-compose.yml#L139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs more info Further information from author of issue is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smacker @dpordomingo @se7entyse7en