Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support UAST cache #83

Open
vmarkovtsev opened this issue Mar 20, 2019 · 4 comments
Open

Feature request: support UAST cache #83

vmarkovtsev opened this issue Mar 20, 2019 · 4 comments
Labels

Comments

@vmarkovtsev
Copy link
Collaborator

It would be great to have an ability to load UASTs from disk instead of parsing files every time. This is critical for ML benchmarks and quality evaluations, where we can analyze 1,000 predefined repositories at the same revisions. Thus we would have more stable timings, more stable experience (some driver may crash, e.g. cpp, or parse differently, e.g. js) and also run faster.

@carlosms carlosms added the enhancement New feature or request label Mar 20, 2019
@carlosms
Copy link
Contributor

ping @smola @src-d/product.

@smacker
Copy link
Contributor

smacker commented Mar 21, 2019

are we talking about UAST parsing for the content of pull requests or about the proxy to bblfshd?

@vmarkovtsev
Copy link
Collaborator Author

vmarkovtsev commented Mar 21, 2019

I meant UASTs which are supplied by the data service built into lookout-sdk binary.

@smacker
Copy link
Contributor

smacker commented Mar 21, 2019

thanks! just a note for Santiago and product:
We can implement caching in lookout itself to avoid parsing the same files for each analyzer and make backend configurable.
So lookout can store them in memory for a short period of time (analyzers are going to request uasts only after the event) and for sdk-bin we can use cache on disk that would solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants