Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong squirrel imports #279

Open
faide opened this issue Jun 28, 2018 · 2 comments
Open

wrong squirrel imports #279

faide opened this issue Jun 28, 2018 · 2 comments

Comments

@faide
Copy link

faide commented Jun 28, 2018

when running a simple go build in the gopkg.in/src-d/go-kallax.v1 directory (resulting from a go get) I get the following error:

# gopkg.in/src-d/go-kallax.v1
./store.go:120:12: undefined: squirrel.DBProxyContext
./store.go:121:12: undefined: squirrel.DBProxyContext

In store.go you import github.com/Masterminds/squirrel but looking at the master of squirrel I do not find any DBProxyContext.
If I checkout gopkg.in/Masterminds/squirrel.v1 I find it.

I suppose you should import gopkg.in/Masterminds/squirrel.v1 and then in a second time investigate if the DBProxyContext is gone for real in the next squirrel release and find a way to stop using it in kallax.

@faide
Copy link
Author

faide commented Jun 28, 2018

After inspection it seems kallax uses the DBProxyContext but only uses the interface of DBProxy so a simple replacement could do the trick.

But, unfortunately it seems squirel Master also removed Lt and Gt from expr.go which kallax makes use of.

I'll change the ticket name to "squirrel incompatible changes"

@faide faide changed the title squirrel.DBProxyContext is undefined squirrel incompatible changes Jun 28, 2018
@faide
Copy link
Author

faide commented Jun 28, 2018

After even more code sifting I infer that you are indeed using squirrel v1 instead of master (master not being used by squirrel itself)

So in fact I think kallax should import squirrel.v1 from gopkg.in instead of github.com

I'll propose a PR to do this

@faide faide changed the title squirrel incompatible changes wrong squirrel imports Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant