Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The auth service is a shared service, but it is not designed to be so. #3

Open
srayner opened this issue Dec 17, 2015 · 1 comment
Open
Labels

Comments

@srayner
Copy link
Owner

srayner commented Dec 17, 2015

Either the design needs to be changed to make this work as a shared service, or the config needs to be changed to make it not shared.

The resource is added to the acl when you call the isAllowed() method. If you call isAllowed() more than once, it will attempt to load the resource into the acl again and potentially fail with an error. This is because it was assumed that a fresh instance of the service is created each time, but that is not the case with a shared service.

@srayner
Copy link
Owner Author

srayner commented Dec 28, 2015

The same is true after delete a privilege. It looks like we are redirecting to list of privileges, but because the id parameter is missing, it is further redirecting to list of resources.

@srayner srayner closed this as completed Dec 28, 2015
@srayner srayner reopened this Dec 28, 2015
@srayner srayner added the bug label Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant