Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Nodes Datasource to be Filtered by Source Id #50

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Allow Nodes Datasource to be Filtered by Source Id #50

merged 1 commit into from
Apr 18, 2024

Conversation

shaswot77
Copy link
Contributor

Description

  • nodes could have same name therefore added ability to filter by sourceId.
  • Datasource will now also return type and sourceId

Checklist:

  • Added a label: bug-fix, feature, or enhancement
  • PR description written

@shaswot77 shaswot77 added the enhancement New feature or request label Apr 17, 2024
@shaswot77 shaswot77 requested a review from P2P-Nathan April 17, 2024 12:26
P2P-Nathan
P2P-Nathan approved these changes Apr 18, 2024
View reviewed changes
Copy link

@P2P-Nathan P2P-Nathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if we have a way to do re-release builds in the future I can test too

@shaswot77 shaswot77 merged commit 1e71ab6 into main Apr 18, 2024
6 checks passed
@shaswot77 shaswot77 deleted the work/ss/scope-filter-by-sourceid branch April 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P2P-Nathan P2P-Nathan P2P-Nathan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaswot77 @P2P-Nathan