Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off/hide any patterns that aren't working #72

Open
cswales opened this issue Nov 11, 2022 · 1 comment
Open

Turn off/hide any patterns that aren't working #72

cswales opened this issue Nov 11, 2022 · 1 comment
Labels
1 HighPriority - chromatik really should get fixed
Milestone

Comments

@cswales
Copy link
Collaborator

cswales commented Nov 11, 2022

Patterns are getting picked up from the jar files rather than from the patterns list, which means that some patterns that compile, but do not work (such as ShrubRiver) are showing up in the UI.

Need to add @LXComponent.Hidden to them to keep them from showing up.

These include:
AutographedPattern (base class, should never show up)
SpiralArms
WavesToMainTree
PartyRings
ScrambleEffect
Brightness (used, just not as a UI selectable class)
Snowflakes
Stringy
Fountain

There may be more that aren't working properly

@mcslee
Copy link
Collaborator

mcslee commented Nov 11, 2022

AutographedPattern (base class, should never show up)

FYI - better solution for these is to just declare that class abstract - LX will notice that it's abstract and won't show it in the UI, and even better Java won't let you even try to directly instantiate it.

For the rest @LXComponent.Hidden ought to work just fine.

@bbulkow bbulkow added the 1 HighPriority - chromatik really should get fixed label Nov 13, 2022
@cswales cswales added this to the Launch milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 HighPriority - chromatik really should get fixed
Projects
None yet
Development

No branches or pull requests

3 participants